Add Sentinel-2 Collection 3 DEA datasets notebook #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
robbibt
requested changes
Dec 2, 2022
There was a problem hiding this comment.
This is brilliant work @geoscience-aman, really nice clean code and great documentation! I've checked out the branch and made a few minor changes, main ones being:
- Adding a bit of extra info to the s2cloudless section, and changing the order the probability and masking layers are introduced
- Added a new section on filtering scenes according to their geometric accuracy
I really liked turning the Description section into a linked contents, so I did that for the Landsat C3 notebook too.
I still need to quickly test this on the NCI to see if it works there, but in the meantime can I get you to make two small changes? (you'll need to first pull the latest version of this branch to get my changes)
- Yep, let's remove the existing
Sentinel2.ipynbnotebook from this folder - it will still be in Github's history if anyone needs it. If it's possible to do a quick search (not exactly sure how) of the repo to update any links that point to the old notebook, that would be fantastic. - I can't seem to find any documentation of this step for some reason, but to make the new notebook appear in the User Guide we need to add it to the index file here: https://github.com/GeoscienceAustralia/dea-notebooks/blob/create_s2_c3_notebook/DEA_datasets/README.rst . If you could put it up the top next to the Landsat one and remove the reference to the older S2 notebook that would be great!
robbibt
approved these changes
Dec 14, 2022
|
Looks great to me, happy to merge when you're ready! 😃 |
robbibt
changed the title
This was referenced Jan 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Sentinel-2 notebook which contains new up-to-date information, including the background from the Sentinel-2 Collection 3 Content Management Interface (CMI) pages.
To flag:
DEA_datasets/Sentinel_2.ipynb)? I have not included the removal of the old notebook as part of this PR.s2cloudlessas an option for Sentinel-2 in theload_ard()function. Update 16/01/2023: Updateload_ardto support Sentinel-2 Collection 3 data, includings2cloudlesscloud masking #984