Add in a lookuptable thumbnail function

[alexgleith]

Add in a way to call the existing function for a singleband lookuptable from the dataset assembler class.

[omad]

Looks like an improvement to me, pushing more code in here from datacube-alchemist.

My only concern, and not a blocker, is that this doesn't go far enough. It's still too method call driven which means extra logic in the client. Maybe we should add parameters to DatasetAssembler.write_thumbnail() and it gets to decide on the method to use to generate the thumbnail...

[alexgleith]

What do you think, @jeremyh? Want me to weave the two functions into a single meta function with two code paths?

[coveralls]

Coverage decreased (-0.1%) to 87.045% when pulling 4045426 on add-lut-thumbnail into 79425c9 on eodatasets3.

[jeremyh]

Looks good. It's different enough of a situation that I don't mind a second function for convenience. Though I like where Damien's coming from.

If combining them means making all the current red/green/blue args optional on the existing function I'd probably prefer not to combine, as their arguments are too different and we'll have a confusing set of completely-mutually-exclusive optional/required parameter combinations on the one function.

---

Perhaps also add a line to one of our minimal tests to run the function, eg:

p.write_thumbnail_singleband('blue', None, bit=1)

to https://github.com/GeoscienceAustralia/eo-datasets/blob/224f97410995e083982fa20ce75fe8e069f8fdbf/tests/integration/test_assemble.py#L200

(I also ran it at first without any bit argument and got a cryptic error message -- we're never checking the bit is None and lookup_table is None case in our old method parameter checking)

[jeremyh]

Bike shedding... should it be write_thumbnail_singleband or write_thumbnail_single_band to have consistent naming style? (we have, for example self.write_measurements_odc_xarray() elsewhere)

[alexgleith]

Bike shedding... should it be write_thumbnail_singleband or write_thumbnail_single_band to have consistent naming style? (we have, for example self.write_measurements_odc_xarray() elsewhere)

I think singleband is a single word... keeping it as it is ;-)

[omad]

Install pre-commit Alex!

[omad]

👯

[jeremyh]

👍