-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signification modification to unittests for the water-atcor-develop branch #115
Merged
sixy6e
merged 78 commits into
opendatacube:water-atcor-develop
from
Oceancolour-RG:water-atcor-develop-rg
Nov 13, 2020
Merged
Signification modification to unittests for the water-atcor-develop branch #115
sixy6e
merged 78 commits into
opendatacube:water-atcor-develop
from
Oceancolour-RG:water-atcor-develop-rg
Nov 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (grid name) in as_geo_docs()
…Sentinel-2's absent level-1 metadata yaml file
Useful when it's potentially very expensive to do all the vector operations to determine the valid region from the data itself.
The old dc_to_stac function is used externally so we need to keep a shim of it for backwards compatibilty.
- Use one session for all downloads - Use a timeout - Keep cached items much longer when they're stable Stac versions. - Allow skipping of the cache - Allow no-network-access usage - Verbose option for users
Cattrs removed 3.6 support, yet it's still trying to install the new version.
… water-atcor-develop
sixy6e
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a lot of changes, but looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit the following changes where made: