Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicly accessible Google API key #581

Open
samsammurphy opened this issue Jul 1, 2020 · 2 comments
Open

Publicly accessible Google API key #581

samsammurphy opened this issue Jul 1, 2020 · 2 comments
Labels
documentation improve the documentation

Comments

@samsammurphy
Copy link
Contributor

An API key for Firebase is stored in config.dev.json which becomes public when uploaded to githhub. Google sends this warning by email..

suspicious
@samsammurphy
Copy link
Contributor Author

Following the API Key restrictions page

Screenshot from 2020-07-01 20-25-44

I set application restrictions to HTTP referrers that come from the earthscope-photos webapp

Screenshot from 2020-07-01 20-27-55

@samsammurphy samsammurphy mentioned this issue Jul 1, 2020
Open
4 tasks
@sebastianovide
Copy link
Contributor

as this is very well explained by Google, perhaps we can just a comment in the read me such as "note: remember to follow Google recommendations that you can find in xyz link".

@sebastianovide sebastianovide added the documentation improve the documentation label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation improve the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianovide @samsammurphy