PlayStationSave: 16x16 icon shenanigans.

[GerbilSoft]

Issue by GerbilSoft
Sunday Oct 16, 2016 at 04:59 GMT
Originally opened as https://github.com/GerbilSoft/rom-properties.reworking/issues/23

---

From the feature/PlayStation.save-file branch:

• Windows seems to screw up the top half of the icon if it's 16x16. Scaling it to 32x32 fixes this.
• Spyro icon has a black background in Windows Explorer's status bar on Windows 7 (and when viewing small enough icons), but not in File Properties. May need forced ARGB32 conversion for icons with any transparency.

The PS1 format isn't as easy as I thought it would be, so it'll be pushed back to 0.9.

EDIT: Maybe it'd be easier to just convert all bitmaps and icons to ARGB32 (or premultiplied ARGB32) before rendering on Windows...

[GerbilSoft]

Comment by GerbilSoft
Sunday Oct 16, 2016 at 19:15 GMT

---

SM64DS icon on Windows 7 is also showing the black background in the status bar and icon view, but not File Properties.

[GerbilSoft]

Comment by GerbilSoft
Sunday Oct 16, 2016 at 21:41 GMT

---

Fixed the black background issue with commit 17ee929 (maybe), but now there's another issue.

Windows 7 expects non-premultiplied for thumbnails and icons, and premultiplied for folder thumbnail previews. I don't know if there's any way to determine which is being requested.

[GerbilSoft]

Comment by GerbilSoft
Sunday Oct 30, 2016 at 18:15 GMT

---

Fixed the top-half icon issue in commit 8d7d357.

The actual issue was Windows requiring a stride of 32px (4 bytes) for monochrome icons. toHBITMAP_mask() didn't handle this, and previously, all icons were a multiple of 32px, so this never showed up before.

toHBITMAP_mask() now handles monochrome icons with "any" width, based on similar code from RpPng_gdiplus.png.

The premultipled alpha issue can't easily be fixed. Oh well.