Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark/light mode toggle switch on navbar #37

Open
3 tasks
brylie opened this issue Nov 26, 2023 · 6 comments · May be fixed by #51
Open
3 tasks

Add a dark/light mode toggle switch on navbar #37

brylie opened this issue Nov 26, 2023 · 6 comments · May be fixed by #51
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brylie
Copy link
Member

brylie commented Nov 26, 2023

Now that Bootstrap 5.3 supports dark and light mode and we have set the dark mode on our base html element, we can allow users to toggle their preferred mode.

Task

  • add a button, icon, or toggle widget on the navbar to allow users to toggle between dark and light mode
  • bonus: user preference is saved across sessions (e.g., localstorage?)
  • bonus: users can save their preference on a "my preferences" page when logged in (this is a stretch goal, so don't worry about it for now)

Resources

@brylie brylie added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 26, 2023
@adrienneli104
Copy link
Contributor

Hey could I be assigned this issue? I would love to contribute!

@adrienneli104
Copy link
Contributor

adrienneli104 commented Nov 27, 2023

Thanks! Would you also be able to assign this issue to @Icyviolet23, @TBennur, and @kc12341? We are a group of university students and would like to implement this feature and the bonus ones as a team.

@brylie
Copy link
Member Author

brylie commented Nov 28, 2023

I can only assign them if they comment in this issue discussion, since GitHub is only showing me the names of people who have commented.

@Icyviolet23
Copy link

I am on Adrienne's team and would like to be assigned to this issue!

@kc12341
Copy link

kc12341 commented Nov 28, 2023

Hi, I'm also on Adrienne's team and would like to be assigned to this issue!

@brylie
Copy link
Member Author

brylie commented Dec 12, 2023

Great work so far on the Dark/Light toggle. I've added some comments on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants