Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow to save an element after all fields have loaded #610

Open
medarob opened this issue Dec 14, 2023 · 3 comments
Open

only allow to save an element after all fields have loaded #610

medarob opened this issue Dec 14, 2023 · 3 comments

Comments

@medarob
Copy link
Contributor

medarob commented Dec 14, 2023

I just ran into a problem where mask deleted all fields of an element.

If I want to edit an element it sometimes takes a while until all fields are shown in the BE mask configurator. (1-2 sec)
If I click on the save button during that short time period, when no fields are shown, mask saves the element with no fields.

In my opinion the save button should be active only when all fields were loaded and shown in the configurator.

@nhovratov
Copy link
Collaborator

I hope you had your json in git 😱

@nhovratov
Copy link
Collaborator

Actually I have no idea how to do this. Right now I just wait for all requests to be done. That is when the splashscreen dissappears. In local development the components are normally rendered almost instantaneously. So in addition I would need to wait until all sub-components are rendered. This isn't so simple, as the number of components is variable. Maybe there is some VueJs Guru outthere who could help?

@medarob
Copy link
Contributor Author

medarob commented Dec 14, 2023

I hope you had your json in git 😱

Yes, the code is in Git so I could do a revert.

I only noticed this because I was saving each element and noticed that on some elements more (missing/additional?) code was added to the mask.json. I haven't changed anything in the elements. So I just opened each element and clicked on the save button and at the last element I was to fast, no fields were loaded and then all the fields were gone after saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants