Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding responsive data tables to React Dash and update demo page #13

Closed
4 of 7 tasks
alexiscott opened this issue Nov 27, 2017 · 8 comments
Closed
4 of 7 tasks
Assignees
Labels

Comments

@alexiscott
Copy link

alexiscott commented Nov 27, 2017

  • Add Jasmine tests
  • Setup react demo page.
  • See why loader does not work.
  • Add bootstrap grid and style loading to react demo page.
  • Add configurable options for settings.js
  • Integrate some generic fixes for console errors in React Dash

QA: pull down branch:

  1. https://github.com/alexiscott/react-dash/tree/integrate-responsive-datatables-library
  2. Run yarn install
  3. Run npm start
  • [ ] confirm that you can see a data table (Responsive DataTables) on the example page: http://localhost:3000/
  • Confirm that it behaves responsively on different browser widths
  • [ ] confirm that you can see a fixed data table on the example page:
@alexiscott alexiscott changed the title Adding responsive data tables to React Dash Adding responsive data tables to React Dash and update demo page Nov 27, 2017
@alexiscott alexiscott self-assigned this Nov 27, 2017
@alexiscott
Copy link
Author

Updated estimate to 8, as this also should include tests.

@alexiscott
Copy link
Author

@iris-i this should be working now, at least enough so it can be used with SCSC.
Future work:

  1. Add configurable options,
  2. look into how this could work with data pulled in using a dataHandler and a data source -
    Currently it will not respond to updates in the backend without a page reload, so it just loads the data on the initial componendDidMount. I found references to how to have it work with live updates but none of them seemed very complete, and could have performance implications. I note them here purely for reference purposes.
    https://medium.com/@zbzzn/integrating-react-and-datatables-not-as-hard-as-advertised-f3364f395dfa
    https://github.com/alecperkey/react-jquery-datatables - this is no longer maintained it seems.
  3. tests are a bit thin on the ground.

Your code review and QA would be much apreciated.

@alexiscott
Copy link
Author

This initial work lacked the ability to handle ASYNC updates. I am working to get that in, and have updated the estimate accordingly.

@alexiscott
Copy link
Author

this should be now updating dynamically.

@erogray
Copy link

erogray commented May 10, 2018

@acouch when cleaning up react-dash, please close this ticket if needed

@erogray erogray assigned acouch and unassigned alexiscott May 10, 2018
@kimwdavidson
Copy link

@acouch Should this still be in blocked? What's blocking it?

@kimwdavidson
Copy link

@acouch is there already a cleanup ticket? can we close this?

@kimwdavidson
Copy link

closing. @acouch to create ticket for remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants