Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape URI #204

Open
ilyakooo0 opened this issue Mar 17, 2020 · 6 comments · May be fixed by #205
Open

Escape URI #204

ilyakooo0 opened this issue Mar 17, 2020 · 6 comments · May be fixed by #205

Comments

@ilyakooo0
Copy link

Escape URIs to be RFC3986-compliant.

For example, it is quite common to have single quotes at the end of Haskell record names.

@fisx
Copy link
Collaborator

fisx commented Mar 18, 2020

Thanks for pointing this out.

I would go about this by replacing the internal URL newtype with uri-bytestring, then it's just a matter of using the library interface correctly. (I don't know if there is any better uri library around.)

Would you be interested in putting together a PR? That would be great! :)

@ilyakooo0
Copy link
Author

ilyakooo0 commented Mar 19, 2020

Is there a reason why you think using uri-bytestring is better than using libraries like modern-uri or network-uri?

EDIT: Read the comment again. Will probably use modern-uri

@fisx
Copy link
Collaborator

fisx commented Mar 19, 2020

Is there a reason why you think using uri-bytestring is better than using libraries like modern-uri or network-uri?

i don't think that, and no reason. :-)

@fizruk any opinions? anybody else?

@ilyakooo0
Copy link
Author

I'm pretty sure it's not as simple as just replacing the URL with URI, since the structure schemas are stored and encoded as just a InsOrdHashMap Text Scheme.

@ilyakooo0
Copy link
Author

I'm having trouble finding where the names from NamedSchema are converted into a URL

@fisx
Copy link
Collaborator

fisx commented Mar 19, 2020

I haven't checked that, and I won't have time this week to do so. It's conceivable that more refactoring and repair work will be required for this.

@ilyakooo0 ilyakooo0 linked a pull request Mar 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants