Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NamedSchema a data type #40

Closed
fizruk opened this issue Jan 20, 2016 · 1 comment
Closed

Make NamedSchema a data type #40

fizruk opened this issue Jan 20, 2016 · 1 comment
Assignees

Comments

@fizruk
Copy link
Member

fizruk commented Jan 20, 2016

To cite @jkarni:

if NamedSchema had an instance for HasParamSchema (which I guess means it shouldn't be a tuple) that would save me the chars . _2, for what it's worth

Having a separate type will also mean Name and Schema will be named fields rather than _1 and _2.

@jkarni
Copy link

jkarni commented Jan 20, 2016

I'm happy to do this, but NamedSchema would have to move (if we want the lenses for it to be in Lenses.hs) to avoid circular imports, and I'll defer to you on where to move it to (or whether to have the lenses elsewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants