Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instances for NonEmpty #93

Closed
phadej opened this issue Mar 15, 2017 · 5 comments
Closed

Add instances for NonEmpty #93

phadej opened this issue Mar 15, 2017 · 5 comments

Comments

@phadej
Copy link
Collaborator

phadej commented Mar 15, 2017

No description provided.

@lucasdicioccio
Copy link

Started something at lucasdicioccio@d748ab7 . I'll take some more time to actually test the thinggy and try whether GHC7 works with the same instance.

(currently using something along these lines at work on a newtype defined over NonEmpty).

@lucasdicioccio
Copy link

Obviously I mixed ToSchema and ToParamSchema in this quick fix before leaving :-). I'll do a proper one later.

@lucasdicioccio
Copy link

Ok, updated
my fix lucasdicioccio@a1dbad9 .

Do you want to discuss over the Pull Request or in this thread? In particular, should I add an instance for GHC<8?

@phadej
Copy link
Collaborator Author

phadej commented Nov 8, 2017

please make a PR, and yes, please add a semigroups dependency, as

  if !impl(ghc >= 8.0)
    build-depends:
        semigroups  >= 0.18.3 && <0.19

(latest semigroups is 0.18.3 atm, no need to push lower bound down, as we won't test that anyway)

@fizruk
Copy link
Member

fizruk commented Mar 9, 2018

Closed in 22e975e.

@fizruk fizruk closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants