Use named ThreadItem and Error instead of generic object & error
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New `Cubscout::ThreadItem` model inheriting from `Cubscout::Object`. This allows for future extension of the thread domain. Raise a `Cubscout::Error` on unavailable methods. Ideally it should be it's own error class inheriting from `Error`, but the API is not quite clear yet.
radanskoric
requested review from
radanskoric
and removed request for
pedjaradenkovic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Cubscout::ThreadItemmodel inheriting fromCubscout::Object. This allowsfor future extension of the thread domain.
Raise a
Cubscout::Erroron unavailable methods. Ideally it should be it's ownerror class inheriting from
Error, but the API is not quite clear yet.