Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor backups add capability #757

Open
tablatronix opened this issue Feb 9, 2014 · 3 comments
Open

refactor backups add capability #757

tablatronix opened this issue Feb 9, 2014 · 3 comments

Comments

@tablatronix
Copy link
Member

create class or proceedural methods for backups, add ability to keep more than one backup, user settable.

Add hooks also.
Add anything else necessary for a plugin to add a diffing capability.

@cnb
Copy link
Contributor

cnb commented Feb 9, 2014

👍

@tablatronix
Copy link
Member Author

create functions for abstraction and security, will be sandboxed to respective folders.
backup
backuppage
restorepage
deletepage

we already have most of these, just are not using them.

@tablatronix
Copy link
Member Author

Changedata does not use createBak, it uses its own copy.

createBak creates files as $file.".bak"

refactor all backup methods to use the function, unless a file is modified to be a different file perhaps we should not change the extension.

however, the undo functionality is not compatible with that. which would indicate that the pages undo does not use the undo function either.

pages uses its own copy for backing up, and restore_bak to undo via backup-edit.php
somewhat inconsistent, would be nice to normalize this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants