Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale dependency emoji-mart bug fails to find emoji for token - #335

Closed
MartinCupela opened this issue Mar 2, 2022 · 0 comments · Fixed by #336
Closed

Stale dependency emoji-mart bug fails to find emoji for token - #335

MartinCupela opened this issue Mar 2, 2022 · 0 comments · Fixed by #336
Assignees
@MartinCupela
Labels
bug Something isn't working

Comments

@MartinCupela
Copy link
Collaborator

If a user types ":-" into StatusUpdateForm then error is thrown. The reason is that the emojiTrigger returns TriggerType with dataProvider that returns an array in form [undefined]. This is caused because the underlying call to NimbleEmojiIndex.search() does not handle correctly search for token - (and -1):

image

https://github.com/missive/emoji-mart/blob/ccd591dd5af5ea21455e65b16c233f4876447b80/src/utils/emoji-index/nimble-emoji-index.js#L99

The indexing by skinTone is redundant, because the BaseEmoji object is already returned by indexing this.emojis['-1']:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinCupela MartinCupela

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: token "-" causes the emoji search to fail in StatusUpdateForm GetStream/react-activity-feed
1 participant
@MartinCupela