fix: replace vertical message margins with padding (theme v1) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petyosi
approved these changes
Sep 30, 2022
arnautov-anton
approved these changes
Sep 30, 2022
MartinCupela
deleted the
fix/remove-vertical-message-margins-theme-v1
branch
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
## [3.5.2](v3.5.1...v3.5.2) (2022-09-30) ### Bug Fixes * replace vertical message margins with padding (theme v1) ([#197](#197)) ([71848b6](71848b6))
|
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MartinCupela
added a commit
that referenced
this pull request
Sep 30, 2022
* fix: replace vertical margins with padding in theme v1 messages * fix: adjust message alignment in thread theme v1
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
## [3.1.2](v3.1.1...v3.1.2) (2022-09-30) ### Bug Fixes * replace vertical message margins with padding (theme v1) ([#197](#197)) ([99dbb31](99dbb31))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix the erratic scroll issue caused by vertical margins around messages in
VirtualizedMessageList. Replace all message margins with padding in vertical axis. The goal is to keep the message spacing same:Additionally the parent message alignment was fixed for virtualized thread.
🛠 Implementation details
Paddings and margins were combined around the messages and so the margin height was added to padding if it existed.
🎨 Demo
adding_messages_VML.webm