fix: remove unnecessary selector specificity from font-family setting #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuperaz
requested review from
arnautov-anton,
MartinCupela,
myandrienko and
oliverlaz
MartinCupela
approved these changes
Apr 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
# [4.15.0](v4.14.0...v4.15.0) (2024-04-25) ### Bug Fixes * remove unnecessary selector specificity from font-family setting ([#292](#292)) ([04e110d](04e110d)) ### Features * **angular:** allow customizing avatar, icon and loading indicator from CSS ([#291](#291)) ([b4d1658](b4d1658)), closes [/github.com/GetStream/stream-video-js/blob/main/packages/styling/src/Icon/Icon-theme.scss#L16](https://github.com//github.com/GetStream/stream-video-js/blob/main/packages/styling/src/Icon/Icon-theme.scss/issues/L16)
|
馃帀 This PR is included in version 4.15.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
Fix this issue: GetStream/stream-chat-angular#603
馃洜 Implementation details
The
font-familysetting is inherited, so there is no need for the extra*selector, which can make integrators' lives harder.馃帹 UI Changes
Add relevant screenshots
Make sure to test with both Angular and React (with both
MessageListandVirtualizedMessageListcomponents) SDKs