Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save Image" attachment action broken #1088

Closed
1 task done
jbryant314 opened this issue Apr 15, 2022 · 3 comments
Closed
1 task done

"Save Image" attachment action broken #1088

jbryant314 opened this issue Apr 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jbryant314
Copy link

Which packages are you using?

stream_chat_flutter

On what platforms did you experience the issue?

iOS, Android

What version are you using?

stream_chat_flutter: 3.6.0

What happened?

I tried to save an image via attachment modal actions, but instead I got a square modal box with a really big negative number and no way to dismiss it on iOS. On Android, you can swipe back to dismiss it. On Android, the image is not saved. on iOS, the image is saved. Attached is a screen recording. Note that I'm using the example code to reproduce, nothing custom.

screen-20220414-164931.mp4

Steps to reproduce

1.  Send or receive an image in a chat channel
2.  Tap on the image
3.  Tap the options in the upper right hand corner of the screen
4.  Tap "Save Image"

Expected: After tapping "Save Image" I see a progress between 0 and 100%, and when it's done saving I can close the progress modal or it closes automatically.

Observed: 

IOS: A progress modal opens and I see a big negative number, seemingly the number of bytes of the file.  Once it's 'done' downloading, the modal remains and there is no way to dismiss it.  The image does seem to successfully save.

Android: Same as above except the image is not saved.

Supporting info to reproduce

See attached screen recording above.

Relevant log output

[no errors are logged]

Flutter analyze output

No response

Flutter doctor output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jbryant314 jbryant314 added the bug Something isn't working label Apr 15, 2022
@ayush221b
Copy link
Contributor

Thank you for pointing this out. This was fixed in our newest v4 beta release. You can try that out here: https://pub.dev/packages/stream_chat_flutter/versions/4.0.0-beta.2

This issue has been mentioned before in #1071

@jbryant314
Copy link
Author

So @ayush221b genuine question. If I want the most stable version of this library which should I choose? The beta? I didn’t see that previous ticket because I searched for open tickets. I’m trying to deploy a stable version of our app to production.

@imtoori
Copy link
Contributor

imtoori commented Apr 15, 2022

@futebolbryant the problem is that the fix required a breaking change to be fixed, so we decided to include it in the v4 release.
I think you could use v4, there should be no issue.
You can give it a try and let us know, we're gonna release a stable one later this month, but it's not gonna take more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants