Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryChannels stop fetching new channels #612

Closed
2 tasks done
gvv-ua opened this issue Aug 6, 2021 · 2 comments · Fixed by #629
Closed
2 tasks done

QueryChannels stop fetching new channels #612

gvv-ua opened this issue Aug 6, 2021 · 2 comments · Fixed by #629
Labels
bug Something isn't working

Comments

@gvv-ua
Copy link

gvv-ua commented Aug 6, 2021

Describe the bug
When we fetch all channels and make pull to refresh after that, pagination stopped work.

What package are you using? What version?
2.1.1

What platform is it about?

  • Android
  • iOS

Steps to reproduce the behavior:

  1. Open chat list screen
  2. Scroll down to the latest channel
  3. Scroll top
  4. Pull to refresh
  5. Scroll down (pagination doesn't work)

Expected behavior
Load new channels with pagination

@gvv-ua gvv-ua added the bug Something isn't working label Aug 6, 2021
@gvv-ua
Copy link
Author

gvv-ua commented Aug 6, 2021

In queryChannels of ChannelsBloc:

final clear = paginationParams.offset == 0;

but _paginationEnded not cleared.

@imtoori
Copy link
Contributor

imtoori commented Aug 17, 2021

hey @gvv-ua thanks for reporting the issue! I'm fixing it right now

@imtoori imtoori linked a pull request Aug 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants