fix: set local device's check for alive websocket connection #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to see if websocket is alive
santhoshvai
requested review from
ferhatelmas,
gumuz,
vishalnarkhede,
madsroskar and
vanGalilea
as code owners
|
Size Change: +367 B (0%) Total Size: 314 kB
|
|
@santhoshvai can you please solve the failing linting/tests? |
fix: liniting issue fix: liniting issues
santhoshvai
force-pushed
the
santhosh/set-local-device-bug
branch
from
94e03f0
to
2eb4e55
Compare
fix: setLocalDevice test
santhoshvai
force-pushed
the
santhosh/set-local-device-bug
branch
from
a82bbe9
to
30fe86c
Compare
madsroskar
approved these changes
Nov 10, 2022
This was referenced Nov 11, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
setLocalDevice was checking for a stale wsconnection class to check if websocket was alive. This is not correct.
Thank you @vishalnarkhede 💯
Changelog