Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: receive last_read_message_id from server #1113

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

shaljam
Copy link
Contributor

@shaljam shaljam commented Apr 11, 2023

receive last_read_msg_id from server

also populate last_read_message_id

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

To create a QA test on the chat project, I needed this library to return a new property.
Corresponding pull request in chat: https://github.com/GetStream/chat/pull/4930

Changelog

  • ReadResponse now includes last_read_msg_id received from server.
  • last_read_message_id is added to type ChannelReadStatus.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

Size Change: +66 B (0%)

Total Size: 317 kB

Filename Size Change
dist/browser.es.js 69.4 kB +14 B (0%)
dist/browser.full-bundle.min.js 37.5 kB +9 B (0%)
dist/browser.js 70.3 kB +16 B (0%)
dist/index.es.js 69.4 kB +13 B (0%)
dist/index.js 70.4 kB +14 B (0%)

compressed-size-action

also populate last_read_message_id
@shaljam shaljam changed the title [PBE-243] Add last read message id in query channel endpoint feat: receive last_read_msg_id from server Apr 12, 2023
@vishalnarkhede vishalnarkhede changed the title feat: receive last_read_msg_id from server feat: receive last_read_message_id from server Apr 13, 2023
@vishalnarkhede
Copy link
Contributor

Approved. But lets merge it after backend changes are deployed :)

@shaljam shaljam merged commit 64e9165 into master Apr 19, 2023
8 checks passed
@shaljam shaljam deleted the last-read-message-id branch April 19, 2023 14:05
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants