Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint sort errors and mode cover in compressImage.ts of native-package #2005

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: eslint sort errors and mode cover in compressImage.ts of native-package #2005

merged 3 commits into from
Mar 14, 2023

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Mar 14, 2023 •
edited
Loading

🎯 Goal

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@khushal87
Copy link
Member Author

Self reviewing and merging it.

@khushal87 khushal87 merged commit 107cfef into develop Mar 14, 2023
@khushal87 khushal87 deleted the khushal87/native-deps-fix branch March 14, 2023 05:09
@github-actions github-actions bot mentioned this pull request Mar 16, 2023
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khushal87 @stream-ci-bot