feat: customize message padding #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santhoshvai - any chance you could review this? I know you guys are very busy with the video library but would be nice to get these released 馃槃 Sorry to pester |
khushal87
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Hey, @aharwood9 Thanks for your contribution. The changes look good to me and hence I will be merging it.
|
馃帀 This PR is included in version 5.18.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
Fixes #2158 by allowing a user to customize the horizontal padding for
MessageList.馃洜 Implementation details
MessageListto use the default intheme.ts. This means the reactions alignment is always in sync rather than having to update bothscreenPaddingand theMessageList.messageContainerso we can apply further custom styling beyond just the padding馃帹 UI Changes
iOS
Proof of working with an extreme 32 horizontal padding -
Android
Proof of working with an extreme 32 horizontal padding -
馃И Testing
鈽戯笍 Checklist
developbranch