Fix: missing Japanese translation #2243

atsss · 2023-09-27T18:31:01Z

🎯 Goal

To remove the following warning

 WARN  Streami18n: Missing translation for key: 3 Replies 
    at ThreadFooterComponentWithContext (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:253771:24)
    at ThreadFooterComponent (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:253856:71)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at VirtualizedListCellContextProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:58851:24)
    at RCTScrollContentView
    at RCTScrollView
    at ScrollView (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:50324:36)
    at ScrollView
    at VirtualizedListContextProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:58833:25)
    at VirtualizedList (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:56655:36)
    at FlatList (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:56313:36)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at MessageListWithContext (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:243471:37)
    at MessageList (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:244082:89)
    at ThreadWithContext (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:253652:44)
    at Thread (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:253704:59)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at MessageInputProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:161852:24)
    at SuggestionsProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:231213:24)
    at ThreadProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182310:24)
    at MessagesProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:124942:24)
    at PaginatedMessageListProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182507:24)
    at TypingProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:231291:24)
    at OwnCapabilitiesProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182274:24)
    at ChannelProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:161332:24)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at KeyboardProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:161466:24)
    at KeyboardCompatibleView (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:238158:36)
    at ChannelWithContext (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:232812:52)
    at Channel (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:234324:59)
    at ActiveChannelsProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:235152:24)
    at ChannelsStateProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:235072:24)
    at ThemeProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:106605:25)
    at TranslationProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182370:24)
    at ChatProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:124897:24)
    at ChatWithContext (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:247990:25)
    at Chat (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:248073:68)
    at RCTSafeAreaView
    at Index (http://localhost:8081/src/screens/threads/Index.bundle//&platform=ios&modulesOnly=true&app=com.cookwithmoment.ios&dev=true&minify=false&runModule=true&shallow=true:25:45)
    at StaticContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:262358:17)
    at EnsureSingleNavigator (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:259465:24)
    at SceneView (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:262269:22)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at CardSheet (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:367027:23)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at AnimatedComponent (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:54075:38)
    at AnimatedComponentWrapper
    at PanGestureHandler (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:203962:38)
    at PanGestureHandler (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:363522:34)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at AnimatedComponent (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:54075:38)
    at AnimatedComponentWrapper
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at Card (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366531:36)
    at CardContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:367078:34)
    at RNSScreen
    at AnimatedComponent (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:54075:38)
    at AnimatedComponentWrapper
    at Suspender (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366406:22)
    at Suspense
    at Freeze (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366425:23)
    at DelayedFreeze (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366121:22)
    at InnerScreen (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366161:36)
    at Screen (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366340:36)
    at MaybeScreen (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366015:24)
    at RNSScreenContainer
    at ScreenContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366265:31)
    at MaybeScreenContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:366004:23)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at Background (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:362407:21)
    at CardStack (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:364026:36)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at SafeAreaProviderCompat (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:363347:25)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at GestureHandlerRootView
    at StackView (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:361909:36)
    at anonymous (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:262101:24)
    at StackNavigator (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:361794:18)
    at Navigator (http://localhost:8081/src/Navigator.bundle//&platform=ios&modulesOnly=true&app=com.cookwithmoment.ios&dev=true&minify=false&runModule=true&shallow=true:55:29)
    at WaitingForChatbotResponseProvider (http://localhost:8081/src/contexts/WaitingForChatbotResponseContext.bundle//&platform=ios&modulesOnly=true&app=com.cookwithmoment.ios&dev=true&minify=false&runModule=true&shallow=true:34:24)
    at MultimediaMessageProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:358019:24)
    at MarkUnreadCountProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:353768:24)
    at ImageGalleryProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:159459:24)
    at AttachmentPickerProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:161240:24)
    at MessageOverlayProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182416:24)
    at TranslationProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182370:24)
    at OverlayProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:182573:56)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at GestureHandlerRootView
    at VideoControlProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:352532:24)
    at StreamChatContextProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:358073:24)
    at SWRConfig$1 (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:305755:22)
    at $29383e587d62412a$export$9f8ac96af4b1b2ae (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:285562:38)
    at ToastProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:296775:25)
    at PortalProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:293783:50)
    at HybridProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:303571:24)
    at ResponsiveQueryProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:272563:14)
    at RNCSafeAreaProvider
    at SafeAreaProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:263755:24)
    at NativeBaseConfigProviderProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:266223:27)
    at NativeBaseProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:303503:33)
    at EnsureSingleNavigator (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:259465:24)
    at BaseNavigationContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:258092:28)
    at ThemeProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:263172:21)
    at NavigationContainerInner (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:263064:26)
    at Providers (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:257491:55)
    at RNCSafeAreaProvider
    at SafeAreaProvider (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:263755:24)
    at App (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:257578:60)
    at ReactNativeProfiler (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:319770:36)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at __Sentry.TouchEventBoundary (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:332514:36)
    at RootApp
    at withDevTools(RootApp) (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:103685:27)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at RCTView
    at View (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48920:43)
    at AppContainer (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:48797:36)
    at main(RootComponent) (http://localhost:8081/index.bundle//&platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.cookwithmoment.ios:85902:28)

🛠 Implementation details

Add the missing Japanese translation

🎨 UI Changes

iOS

Before	After

Android

Before	After

🧪 Testing

☑️ Checklist

I have signed the Stream CLA (required)
PR targets the develop branch
Documentation is updated
New code is tested in main example apps, including all possible scenarios
- SampleApp iOS and Android
- Expo iOS and Android

atsss · 2023-09-27T18:33:53Z

package/src/i18n/ja.json

@@ -52,7 +52,7 @@
  "You": "あなた",
  "{{ firstUser }} and {{ nonSelfUserLength }} more are typing": "{{ firstUser }}と{{ nonSelfUserLength }}人がタイピングしています",
  "{{ index }} of {{ photoLength }}": "{{ index }} / {{ photoLength }}",
-  "{{ replyCount }} Thread Replies": "{{ replyCount }}件のスレード返信",
+  "{{ replyCount }} Thread Replies": "{{ replyCount }}件のスレッド返信",


This is incorrect Japanese. I also corrected it while I was fixing the warning.

* fix: long message content overflowing issue in overlay (#2244) * fix: missing Japanese translation (#2243) * Correct Japanese translation for thread * Add missing Japanese translation for thread * fix: url param serialisation issue on iOS 17 (#2246) --------- Co-authored-by: atsss <atsushi0623itoh@gmail.com>

stream-ci-bot · 2023-10-04T09:22:37Z

🎉 This PR is included in version 5.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

atsss added 2 commits September 27, 2023 18:42

Correct Japanese translation for thread

56cb971

Add missing Japanese translation for thread

b8f42f8

atsss commented Sep 27, 2023

View reviewed changes

vishalnarkhede approved these changes Sep 28, 2023

View reviewed changes

atsss changed the title ~~Fix Japanese i18n~~ Fix: missing Japanese translation Sep 28, 2023

vishalnarkhede merged commit ed2754f into GetStream:develop Sep 28, 2023
3 of 4 checks passed

atsss deleted the atsss/fix-japanese-i18n branch September 28, 2023 21:13

github-actions bot mentioned this pull request Oct 3, 2023

Next Release #2247

Merged

6 tasks

stream-ci-bot added the released label Oct 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: missing Japanese translation #2243

Fix: missing Japanese translation #2243

atsss commented Sep 27, 2023

atsss Sep 27, 2023

stream-ci-bot commented Oct 4, 2023

Fix: missing Japanese translation #2243

Fix: missing Japanese translation #2243

Conversation

atsss commented Sep 27, 2023

🎯 Goal

🛠 Implementation details

🎨 UI Changes

🧪 Testing

☑️ Checklist

atsss Sep 27, 2023

Choose a reason for hiding this comment

stream-ci-bot commented Oct 4, 2023