fix: adjust the first message rendering for DateSeparator in empty VirtualizedMessageList #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtualizedMessageList
MartinCupela
requested review from
oliverlaz,
myandrienko and
arnautov-anton
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2271 +/- ##
=========================================
Coverage ? 84.86%
=========================================
Files ? 344
Lines ? 7609
Branches ? 2119
=========================================
Hits ? 6457
Misses ? 806
Partials ? 346 ☔ View full report in Codecov by Sentry. |
myandrienko
approved these changes
Feb 13, 2024
arnautov-anton
approved these changes
Feb 13, 2024
|
Size Change: +27 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
## [11.8.0](v11.7.0...v11.8.0) (2024-02-13) ### Bug Fixes * adjust the first message rendering for DateSeparator in empty VirtualizedMessageList ([#2271](#2271)) ([8f490fa](8f490fa)) * export DefaultStreamChatGenerics ([#2266](#2266)) ([6a928f6](6a928f6)) * prevent mine attr from spreading on message actions box div ([#2270](#2270)) ([1625471](1625471)) * remove mark read functionality from ChannelPreview ([#2273](#2273)) ([3be1ec5](3be1ec5)) ### Features * implement message bounce flow ([#2254](#2254)) ([3878e2f](3878e2f)) * keep unread channel UI when unread channel is marked read on mount ([#2267](#2267)) ([2abe352](2abe352))
|
🎉 This PR is included in version 11.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent including date separator messages in the prepended item count in VML. Prepended item count represents the number of messages loaded during the pagination. These are prepended. A special case of scenario is in empty channel when the messages change the order after being sent and then updated on WS event - their timestamps change and so does their order. That could create artificial prepend count that is incorrect.
This PR fixes a problem, when date separator that is present in the list from the beginning starts to be counted as a prepended message, which is not correct.
fixes #2228