fix: make setChannels prop optional for ChannelSearch #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 353 353
Lines 8051 8051
Branches 2123 2123
=======================================
Hits 6862 6862
Misses 1005 1005
Partials 184 184 ☔ View full report in Codecov by Sentry. |
|
Size Change: +30 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
@myandrienko why is it important to make this optional for the hook. Do we want to make this hook publicly available? |
@MartinCupela the hook Currently, if you want to use |
oliverlaz
approved these changes
Apr 9, 2024
MartinCupela
approved these changes
Apr 9, 2024
|
🎉 This PR is included in version 11.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
setChannelsis used by theChannelSearchcomponent to update the channel list state to include the selected search result. When rendered by theChannelList, it actually passes its ownsetChannelssetter there.But this behavior should be optional, because it's totally valid to use search outside of the
ChannelList.