Make ChannelConfig.commands non-optional
#1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtaStavik
approved these changes
Jun 11, 2021
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - `textDidChange` -> `handleTextChange` | |||
| If you've subclassed UI components and overridden these functions, you should rename your overrides. | |||
| For more information, see (#1177)[https://github.com/GetStream/stream-chat-swift/pull/1177] and [#1178](https://github.com/GetStream/stream-chat-swift/issues/1178) | |||
| - `ChannelConfig.commands` is no longer an optional | |||
Codecov Report
@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 217 217
Lines 9261 9261
=======================================
Hits 8450 8450
Misses 811 811
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Backend doesn't send `commands` when it's empty and we initialize it as empty when it's missing, it doesn't need to be optional
b-onc
force-pushed
the
channelconfig-commands-nonoptional
branch
from
59eb246
to
f8e1574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend doesn't send
commandswhen it's empty and we initialize it as empty when it's missing, it doesn't need to be optional