[CIS-929] UserSearch with given Query #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 91.25% 91.25% -0.01%
==========================================
Files 217 217
Lines 9277 9292 +15
==========================================
+ Hits 8466 8479 +13
- Misses 811 813 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nuno-vieira
reviewed
Jul 2, 2021
Comment on lines
208
to
210
| print("### search with query :\(query)") | ||
| userQueryUpdater.update(userListQuery: query, policy: .replace) { error in | ||
| print("### search complete") |
There was a problem hiding this comment.
So it's possible to make custom searches and usable with multi-tenancy
With this change, users can customize the suggestions search query, most apparent example is multi-tenancy (it doesn't work as of now)
b-onc
force-pushed
the
cis-929-usersearch-query
branch
from
aee3790
to
970ebc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, customizing mentions to work with multi-tenancy is possible. This also opens possibility of using UserSearchController is a variety of custom manners