[CIS-1071] Fix member removed from Channel still present in MemberListController #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
added
🐞 Bug
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
- Coverage 91.15% 91.01% -0.14%
==========================================
Files 227 227
Lines 9763 9767 +4
==========================================
- Hits 8899 8889 -10
- Misses 864 878 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dmigach
approved these changes
Jul 27, 2021
b-onc
force-pushed
the
cis-1071-memberlist-not-updated
branch
from
29f7b73
to
eef3f0c
Compare
b-onc
force-pushed
the
cis-1071-memberlist-not-updated
branch
2 times, most recently
from
63206b9
to
e1386c4
Compare
|
@dmigach @DominikBucher12 why are you approving a PR with broken CI? |
b-onc
force-pushed
the
cis-1071-memberlist-not-updated
branch
2 times, most recently
from
bc23e19
to
3c09ce3
Compare
added 2 commits
August 2, 2021 13:53
This happened because we forgot to update the queries of Member when it's removed. A similar bug may be present in MemberAdded and MemberUpdated events. For those events, we need to re-fetch the queries, since Client doesn't have a way to apply filters.
The new test somehow keeps failing on CI.. perhaps dividing it into 2 will fix it?
b-onc
force-pushed
the
cis-1071-memberlist-not-updated
branch
from
3c09ce3
to
9a5eb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because we forgot to update the queries of Member when it's removed. A similar bug may be present in MemberAdded and MemberUpdated events. For those events, we need to re-fetch the queries, since Client doesn't have a way to apply filters.