Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1073] Change ContainerStackView assertions #1328

Merged
merged 1 commit into from Jul 29, 2021

Conversation

b-onc
Copy link
Contributor

@b-onc b-onc commented Jul 28, 2021

UIContainerView has these operations as no-op and so should we

@b-onc b-onc added the 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK label Jul 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1328 (23f660c) into main (c91f90b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         227      227           
  Lines        9750     9750           
=======================================
  Hits         8872     8872           
  Misses        878      878           
Flag Coverage Δ
llc-tests 90.99% <ø> (ø)
llc-tests-ios12 90.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91f90b...23f660c. Read the comment docs.

Copy link
Contributor

@DominikBucher12 DominikBucher12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳🇮🇹

UIContainerView has these operations as no-op and so should we
@b-onc b-onc force-pushed the cis-1073-containerstackview-assert branch from 23f660c to 2146e53 Compare July 29, 2021 09:06
@b-onc b-onc merged commit 0cbf1a0 into main Jul 29, 2021
@b-onc b-onc deleted the cis-1073-containerstackview-assert branch July 29, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants