Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1101] Fix jumps when presenting message popup actions in a modal #1361

Merged

Conversation

nuno-vieira
Copy link
Member

Description of the pull request

Fixes a UI jump glitch when opening the message actions popup when the message list is presented in a modal.

Before
before
After
after

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Aug 11, 2021
@nuno-vieira nuno-vieira requested a review from b-onc August 11, 2021 12:07
@codecov-commenter
Copy link

Codecov Report

Merging #1361 (fd3f206) into main (93c566f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         224      224           
  Lines        9807     9807           
=======================================
  Hits         8899     8899           
  Misses        908      908           
Flag Coverage Δ
llc-tests 90.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c566f...fd3f206. Read the comment docs.

Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested with the SwiftUI test app from H, right?
CHANGELOG please

@nuno-vieira nuno-vieira merged commit 2d2dc5e into main Aug 11, 2021
@nuno-vieira nuno-vieira deleted the CIS-1101-Fix-jumps-presenting-message-actions-in-modals branch August 11, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants