Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1082] Internet connection handling #1449

Merged
merged 4 commits into from Sep 14, 2021

Conversation

evsaev
Copy link
Contributor

@evsaev evsaev commented Sep 13, 2021

This PR updates ChatClient to disconnect immediately when the Internet connection disappears

@evsaev evsaev added the 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Sep 13, 2021
@evsaev evsaev self-assigned this Sep 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #1449 (322c108) into main (4bb1571) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   88.25%   88.33%   +0.08%     
==========================================
  Files         229      229              
  Lines       10327    10356      +29     
==========================================
+ Hits         9114     9148      +34     
+ Misses       1213     1208       -5     
Flag Coverage Δ
llc-tests 88.33% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/StreamChat/ChatClient.swift 93.68% <100.00%> (+0.49%) ⬆️
.../Utils/InternetConnection/InternetConnection.swift 58.55% <0.00%> (+4.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb1571...322c108. Read the comment docs.

@evsaev evsaev force-pushed the CIS-1082-internet-connection-handling branch from f9737e2 to 322c108 Compare September 13, 2021 20:06
@tbarbugli tbarbugli merged commit 9e93159 into main Sep 14, 2021
@tbarbugli tbarbugli deleted the CIS-1082-internet-connection-handling branch September 14, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants