Improve Logger experience #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evsaev
suggested changes
Oct 11, 2021
b-onc
force-pushed
the
logger-improvements
branch
from
04e368f
to
8f3c027
Compare
evsaev
reviewed
Oct 12, 2021
| @@ -66,11 +69,17 @@ open class BaseLogDestination: LogDestination { | |||
| self.showFunctionName = showFunctionName | |||
| } | |||
|
|
|||
| /// Checks if this destination is enabled for the given level | |||
| open func isEnabled(level: LogLevel) -> Bool { | |||
| assertionFailure("`isEnabled(level:)` is deprecated, please use `isEnabled(level:subsystem:)`") | |||
There was a problem hiding this comment.
We preserved the APIs but if customers call super.isEnabled(level) they'll see a crash when running the app in DEBUG, right?
There was a problem hiding this comment.
Yep, they'll immediately spot the crash though
- LogConfig changes will now re-create Logger - Introducing `subsystems` to allow finer control in logging
b-onc
force-pushed
the
logger-improvements
branch
from
8f3c027
to
5689802
Compare
Codecov Report
@@ Coverage Diff @@
## main #1522 +/- ##
==========================================
- Coverage 88.32% 87.89% -0.43%
==========================================
Files 231 232 +1
Lines 10850 10950 +100
==========================================
+ Hits 9583 9625 +42
- Misses 1267 1325 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subsystemsto allow finer control in logging15 minute break PR since I got fed up with uninformative flood of Database log messages. This is used as:
The
subsystemdefinition is open for discussion, manually specifying subsystems seems like to lot of burden for developers to not forget. Alternative would be injecting a Logger instance, which required more changes.