Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for 2.0 #155

Merged
merged 5 commits into from Apr 3, 2020
Merged

Small fixes for 2.0 #155

merged 5 commits into from Apr 3, 2020

Conversation

buh
Copy link
Contributor

@buh buh commented Apr 3, 2020

If the app state is active after the Internet connection is ready.

@buh buh requested a review from b-onc April 3, 2020 12:30
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #155 into master will increase coverage by 1.08%.
The diff coverage is 38.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   44.53%   45.61%   +1.08%     
==========================================
  Files         111      111              
  Lines        5533     5542       +9     
==========================================
+ Hits         2464     2528      +64     
+ Misses       3069     3014      -55     
Impacted Files Coverage Δ
Sources/Client/Client/Client+Devices.swift 0.00% <0.00%> (ø)
Sources/Client/Client/ClientError.swift 0.00% <0.00%> (ø)
Sources/Client/Extensions/Array+Extensions.swift 0.00% <0.00%> (ø)
Sources/Client/Extensions/Bundle+Extensions.swift 50.00% <ø> (ø)
Sources/Client/Extensions/Codable+Extensions.swift 64.70% <ø> (ø)
Sources/Client/Extensions/Data+Extensions.swift 50.00% <ø> (ø)
Sources/Client/Extensions/String+Extensions.swift 50.98% <0.00%> (ø)
Sources/Client/Model/BanEnabling.swift 0.00% <ø> (ø)
...ources/Client/Model/Channel/ChannelExtraData.swift 0.00% <0.00%> (ø)
Sources/Client/Model/Channel/ChannelId.swift 58.33% <ø> (ø)
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b9fed...a35aa2c. Read the comment docs.

@buh buh changed the title Fixed connection Small fixes for 2.0 Apr 3, 2020
CHANGELOG.md Outdated
@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0


### 🐞 Fixed
- Connection issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue link to 155 would be appreciated!

Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment about links in changelog, else LGTM

@Stream-iOS-Bot
Copy link
Collaborator

1 Warning
⚠️ Tests were not updated

Generated by 🚫 Danger

@buh buh merged commit e4bed90 into master Apr 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the connection-fix branch April 3, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants