[CIS-1207, CIS-1232] Fix crash and swapping the long-pressed message on ChatMessagePopupVC

[evsaev]

🔗 Issue Link

CIS-1207, CIS-1232

🎯 Goal

• Fix crash when ChatMessagePopupVC is dismissed when the message is outside the visible area of the message list
• Fix behavior when a long-pressed message is swapped with a newly received message when they have the same style

🛠 Implementation

Stop passing ChatMessageContentView across the message list and pop-up view hierarchies and pass the copy instead.

Therefore, the following subviews are removed from MessageActionsTransitionController:

• messageContentViewFrame
• messageContentViewActivateConstraints
• messageContentViewDeactivateConstraints
• messageContentView
• messageContentViewSuperview
• mainContainerTopAnchor

🧪 Testing

Manual testing:

• Launch DemoApp on 2 devices
• Sign in as Luke and Leia
• Open the channel where both users are members
• Send text message as Luke, observe the message received by Leia
• Long press the message by Leia
• Send another text message as Luke

Expected result:
The message long-pressed by Leia is not swapped with the new message

🎨 Changes

The message inside the pop-up is not swapped:

no-swap.mov

When the pop-up is shown giffy restarts but plays smoothly because the actual view is used while the transition and not the snapshot:

smooth.gif.mp4

☑️ Checklist

• I have signed the Stream CLA (required)
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Affected documentation updated (docusaurus, tutorial, CMS (task created)

[codecov]

Codecov Report

Merging #1596 (2b7b218) into main (10ff049) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   85.29%   85.24%   -0.05%     
==========================================
  Files         232      232              
  Lines       10838    10838              
==========================================
- Hits         9244     9239       -5     
- Misses       1594     1599       +5     

Flag	Coverage Δ
llc-tests	85.24% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eamChat/APIClient/Endpoints/Payloads/RawJSON.swift	84.61% <0.00%> (-12.83%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ff049...2b7b218. Read the comment docs.

[nuno-vieira]

LGTM! 🎉 Nice job 👍