Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MOV attachment mime type encoding #1604

Merged
merged 1 commit into from Nov 10, 2021
Merged

Conversation

b-onc
Copy link
Contributor

@b-onc b-onc commented Nov 10, 2021

馃幆 Goal

Android SDK wasn't able to parse our video attachments.

馃洜 Implementation

It turned out that iOS reports the file name uppercased (eg TRIMMED_FILE123.MOV) and we couldn't detect it was a video (MOV) so we encoded it as generic (octet-stream)

馃И Testing

Enable logs and upload a video attachment, check the encoded mime type.

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@b-onc b-onc added 馃悶聽Bug An issue or PR related to a bug 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1604 (5224467) into main (0411596) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   85.28%   85.31%   +0.03%     
==========================================
  Files         232      232              
  Lines       10932    10936       +4     
==========================================
+ Hits         9323     9330       +7     
+ Misses       1609     1606       -3     
Flag Coverage 螖
llc-tests 85.31% <100.00%> (+0.03%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...treamChat/Models/Attachments/AttachmentTypes.swift 86.66% <100.00%> (+0.95%) 猬嗭笍
Sources/StreamChat/Utils/Logger/Logger.swift 58.53% <0.00%> (+1.82%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0411596...5224467. Read the comment docs.

@b-onc b-onc merged commit b335f9d into main Nov 10, 2021
@b-onc b-onc deleted the video-attachment-mimetype branch November 10, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悶聽Bug An issue or PR related to a bug 馃寪聽SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants