[CIS-1367] Remove unnecessary API calls from ChannelVC and ChannelListVC

[tbarbugli]

🔗 Issue Link

CIS-1367

🎯 Goal

Fix sending multiple unnecessary pagination requests when ChannelListVC and ChannelVC are shown.
This PR makes sure that only 1 API call is made to load both ChannelListVC and ChannelVC

🎨 Changes

Before this PR ChannelListVC was calling the Query Channels endpoint 3 times!

ChannelListVC

• Pagination was incorrectly firing the request to load another page
• The make method was calling the setUp method (which calls synchronize)

ChannelVC

• Pagination was incorrectly firing the request to load another page

☑️ Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Affected documentation updated (docusaurus, tutorial, CMS (task created)

[codecov]

Codecov Report

Merging #1706 (f321160) into develop (def5be4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1706   +/-   ##
========================================
  Coverage    85.21%   85.21%           
========================================
  Files          231      231           
  Lines        11089    11089           
========================================
  Hits          9450     9450           
  Misses        1639     1639           

Flag	Coverage Δ
llc-tests	85.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def5be4...f321160. Read the comment docs.

[evsaev]

Looks good, just some small comments regarding naming 👍 Let's wait for the green light from Adam and we will be good to 🚢 Do we need a changelog entry for this, btw?

[nuno-vieira]

Requesting change just to make sure we revert that code. Other than that LGTM 👍

[adamrushy]

Tested across the make function and removing the setUp call, all is working as expected and I also checked the Storyboard implementation and is all good. Just a conflict and a few other questions to answer then good to go 👍🏼

[nuno-vieira]

LGTM! 🚀