[CIS-1554] Make SendButton animation overridable
#1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
changed the title
SendButton animation overridable
Codecov Report
@@ Coverage Diff @@
## develop #1781 +/- ##
===========================================
- Coverage 85.41% 85.39% -0.03%
===========================================
Files 234 234
Lines 11261 11261
===========================================
- Hits 9619 9616 -3
- Misses 1642 1645 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
adamrushy
approved these changes
Feb 7, 2022
| @@ -28,4 +24,13 @@ open class SendButton: _Button, AppearanceProvider { | |||
| let disabledStateImage = appearance.images.sendArrow.tinted(with: buttonColor) | |||
| setImage(disabledStateImage, for: .disabled) | |||
| } | |||
|
|
|||
| /// The animation when the `isEnabled` state changes. | |||
| open func isEnabledChangeAnimation() { | |||
There was a problem hiding this comment.
Would it make more sense for this public function to pass in the isEnabled param? Approving anyway more of a small suggestion :)
There was a problem hiding this comment.
I see.. yes it kinda makes sense 👍
nuno-vieira
deleted the
fix/CIS-1554-Make-SendButton-animation-overridable
branch
nuno-vieira
added a commit
that referenced
this pull request
Feb 9, 2022
* Make SendButton animation overridable * Update CHANGELOG.md * Feedback changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
CIS-1554
🎯 Goal
Currently, the animation of SendButton is done on the didSet observer of the
SendButton.isEnabled, the problem with this is that thedidSetimplementation is not overridable. We need to extract the animation to a different function so that the customer can override it.🛠 Implementation
Extract the animation to a different function so that the customer can override it.
🎨 Changes
N/A
🧪 Testing
N/A
☑️ Checklist