Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1582] Fix ChatMentionSuggestionView permanently hiding subviews #1800

Merged

Conversation

evsaev
Copy link
Contributor

@evsaev evsaev commented Feb 17, 2022

🔗 Issue Link

CIS-1582

🎯 Goal

Fix issue in ChatMentionSuggestionView when once hidden subview was never shown again. This happens when users without the name are suggested.

🛠 Implementation

Manipulate isHidden depending on the text that is displayed.

🎨 Changes

after.mp4

🧪 Testing

Manual testing:

  • Run DemoApp
  • Create a group channel where one user does not have name
  • Type @ in the channel multiple times

See that the name label is hidden only for the user without name and always shown for other.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@evsaev evsaev added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Feb 17, 2022
@evsaev evsaev requested a review from a team as a code owner February 17, 2022 09:03
@evsaev evsaev self-assigned this Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1800 (331234a) into develop (2d16609) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1800   +/-   ##
========================================
  Coverage    85.44%   85.44%           
========================================
  Files          234      234           
  Lines        11262    11262           
========================================
  Hits          9623     9623           
  Misses        1639     1639           
Flag Coverage Δ
llc-tests 85.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d16609...331234a. Read the comment docs.

nuno-vieira
nuno-vieira previously approved these changes Feb 17, 2022
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Update: We can potentially create a new test to verify it works as intedent

@nuno-vieira nuno-vieira dismissed their stale review February 17, 2022 13:08

Missing new test case

@evsaev evsaev force-pushed the fix/CIS-1582-suggestion-view-permanently-hides-subviews branch from 0756950 to 331234a Compare February 17, 2022 14:50
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@evsaev evsaev merged commit 5859f80 into develop Feb 17, 2022
@evsaev evsaev deleted the fix/CIS-1582-suggestion-view-permanently-hides-subviews branch February 17, 2022 15:16
@testableapple testableapple mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants