[CIS-1582] Fix ChatMentionSuggestionView
permanently hiding subviews
#1800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
CIS-1582
🎯 Goal
Fix issue in
ChatMentionSuggestionView
when once hidden subview was never shown again. This happens when users without thename
are suggested.🛠 Implementation
Manipulate
isHidden
depending on the text that is displayed.🎨 Changes
after.mp4
🧪 Testing
Manual testing:
DemoApp
name
@
in the channel multiple timesSee that the
name
label is hidden only for the user withoutname
and always shown for other.☑️ Checklist