[CIS-295] Channels pagination #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantergo
added
the
🌐 SDK: StreamChat (LLC)
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 84.19% 84.15% -0.04%
==========================================
Files 94 94
Lines 3536 3541 +5
==========================================
+ Hits 2977 2980 +3
- Misses 559 561 +2
Continue to review full report at Codecov.
|
VojtaStavik
approved these changes
Aug 27, 2020
Comment on lines
+245
to
+249
| controller.loadNextChannels(limit: limit) { [callbackQueueID] error in | ||
| AssertTestQueue(withId: callbackQueueID) | ||
| XCTAssertNil(error) | ||
| completionCalled = true | ||
| } |
There was a problem hiding this comment.
Smells like we should create some abstraction for this boilerplate, too. It's everywhere.
There was a problem hiding this comment.
Probably yes. Will think about it when will touch this again :)
VojtaStavik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
ChannelListControllerSampleAppQ: I’m not doing any checks for empty
channelsinloadNextChannelsfunction cause it’s not an issue to have 0 offset. But there is a possibility that this function will be called successfully beforestartUpdatingcall. (channelshas empty array as fallback value) If we want to restrict this we can check for controllerstatebut I’m not sure if we should do that.