Fix plus signs in User fields becoming spaces in the set user request #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 89.27% 89.28%
=======================================
Files 157 157
Lines 5940 5945 +5
=======================================
+ Hits 5303 5308 +5
Misses 637 637
Continue to review full report at Codecov.
|
VojtaStavik
force-pushed
the
fix/v2/set_user_encoding
branch
from
6b8e3aa
to
a4124f4
Compare
b-onc
approved these changes
Oct 28, 2020
|
@VojtaStavik the bug also existed in v3. Your test was passing because you weren't checking the final absolute string to see if the plus was encoded. Should be fine now. |
cardoso
added a commit
that referenced
this pull request
Feb 10, 2021
…#572) * Fix JSON encoding of query-allowed characters in set(user:) request * Update CHANGELOG.md * Add non-aplhanumeric characters to GET body encoding test * Fix plus sign encoding in v3 GET request body Co-authored-by: Vojta Stavik <stavik@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default encoding when building the query parameter with
URLQueryItemwill not encode the + symbols, thus making them become spaces. I fixed it by appending thejsonquery parameter manually with the proper percent encoding to include the plus sign.This can be specially annoying if a field is a base64 string, like an encoded public key, but it's also preventing creating a user with a plus in the name which is valid in other clients such as the JS client.
Example:
mhPcgwhH8L8FqFni20qLZ/bIHbwleWvaqm+zcByNp4FWQj0ufl8H9cHV/pbAYo74gCEUdH/MxXdtX+SmW2o3Rg==
becomes
mhPcgwhH8L8FqFni20qLZ/bIHbwleWvaqm zcByNp4FWQj0ufl8H9cHV/pbAYo74gCEUdH/MxXdtX SmW2o3Rg==
which is invalid base64