[CIS-733] Load expensive CoreData properties lazily #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olejnjak
force-pushed
the
CIS-733-cd-performance
branch
from
c12c00d
to
11d81ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
==========================================
- Coverage 87.21% 87.14% -0.07%
==========================================
Files 238 238
Lines 9102 9147 +45
==========================================
+ Hits 7938 7971 +33
- Misses 1164 1176 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
olejnjak
force-pushed
the
CIS-733-cd-performance
branch
from
86b80d7
to
61936f9
Compare
VojtaStavik
suggested changes
Mar 23, 2021
Sources/StreamChat/Controllers/ChannelController/ChannelController+SwiftUI_Tests.swift
Outdated
Show resolved
Hide resolved
olejnjak
force-pushed
the
CIS-733-cd-performance
branch
3 times, most recently
from
b0f6559
to
844f116
Compare
DominikBucher12
approved these changes
Mar 23, 2021
| $_latestReactions = { | ||
| Set( | ||
| MessageReactionDTO | ||
| .loadLatestReactions(for: dto.id, limit: 5, context: context) |
There was a problem hiding this comment.
Hardcoded limit is okay? Same for line 459.
There was a problem hiding this comment.
Not sure, just moved the original code to make compiler happy. In ChannelDTO there is originally a TODO for that.
olejnjak
force-pushed
the
CIS-733-cd-performance
branch
from
844f116
to
fcded8b
Compare
VojtaStavik
approved these changes
Mar 23, 2021
VojtaStavik
force-pushed
the
CIS-733-cd-performance
branch
from
fcded8b
to
f463c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some
asModelfunction performance by loading expensive top level properties lazily. This means that affected model structs are now thread-confined which should be addressed later as it does not make much sense for value types.Some other changes were necessary:
@Cachedwrapper now hascomputeValueclosure asprojectedValueas otherwise it cannot be set from outside as_cachedWrapperproperty is private ➡️ this will not be possible as__mentionedUsersis inaccessible because it is private automaticallyI consider the semantic change of
_ChatChanneland_ChatMessageto be breaking so it is marked this way in changelog, even though the API remains unchanged.