Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: general maintenance of ci/cd #504

Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat: general maintenance of ci/cd #504

merged 2 commits into from
Apr 28, 2022

Conversation

peterdeme
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2022

Size Change: 0 B

Total Size: 98.5 kB

ℹ️ View Unchanged
Filename Size
dist/js_min/getstream.js 30.9 kB
dist/js/getstream.js 67.6 kB

compressed-size-action

@MartinCupela
Copy link
Collaborator

MartinCupela commented Apr 21, 2022

@peterdeme have you considered using semantic-release package for release automation?

Here is a PR that adds it to a JS package:
GetStream/mml-react#48

Docs:
https://semantic-release.gitbook.io/semantic-release/usage/getting-started

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas
Copy link
Contributor

@peterdeme have you considered using semantic-release package for release automation?

we're using the same pattern for all backend SDKs, changing out of scope of this iteration but could be considered for all in another iteration cc @peterdeme

@MartinCupela
Copy link
Collaborator

@peterdeme there are 2 failed jobs in the CI. Will you still work on that?

@ferhatelmas
Copy link
Contributor

@MartinCupela failure was independent of this change

@ferhatelmas ferhatelmas merged commit f35b66d into main Apr 28, 2022
@ferhatelmas ferhatelmas deleted the modernize branch April 28, 2022 19:37
@github-actions github-actions bot mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants