Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No user_id enrichment option for batch getActivities #608

Open
lavirez opened this issue May 28, 2024 · 0 comments
Open

No user_id enrichment option for batch getActivities #608

lavirez opened this issue May 28, 2024 · 0 comments

Comments

@lavirez
Copy link

lavirez commented May 28, 2024

Hey there I have used your SDK in the following code, I used user_id and it was just fine it filtered the ownReactions by the given user_id.

(async function () {
  try {
    const response = await client.getActivities({
      ids: ['<activity_id>'],
        user_id:
        '<user_id>',
      reactions: {
        
        recent: true,
        counts: true,
        own: true,
        kind: true,
      },
    });
  } catch (error) {
    console.log(error);
  }
})();

However in SDK source code the EnrichOptions is defined as following:

export type EnrichOptions = {
  enrich?: boolean;
  ownReactions?: boolean; // best not to use it, will be removed by client.replaceReactionOptions()
  reactionKindsFilter?: string[]; // TODO: add support for array sample: kind,kind,kind
  recentReactionsLimit?: number;
  withOwnChildren?: boolean;
  withOwnReactions?: boolean;
  withReactionCounts?: boolean;
  withRecentReactions?: boolean;
  withUserId?: string;
};

There's no user_id what's the deal with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant