Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces for the Feed and the Client #82

Closed
olix21 opened this issue Oct 11, 2019 · 1 comment · Fixed by #85
Closed

Add interfaces for the Feed and the Client #82

olix21 opened this issue Oct 11, 2019 · 1 comment · Fixed by #85
Assignees

Comments

@olix21
Copy link
Contributor

olix21 commented Oct 11, 2019

Hi,

I think it should be a great idea to implements interfaces in this project.
We are using the SDK in Symfony, and we are trying to cover our code with some behat tests.
By implementing some interfaces, I could be able to create Dummies of the Feed and the Client objects in my tests.

I Can do a PR for that, do you have any good practice for that? Naming conventions, specific namespace?
I'm also wondering why all the methods are public? Some of them seem to be internal and should be protected/private, no?

@tbarbugli
Copy link
Member

@olix21 I like your idea of adding interfaces to make testing easier, PRs for that are very welcome :)

We don't have a formal definition for naming conventions but the package is pretty consistent (and small) so that should be fairly easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants