Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panning, Add DartCodeViewer, Add Multi Theme support #17

Merged
merged 13 commits into from Aug 16, 2022

Conversation

devbrandonlong
Copy link
Contributor

@devbrandonlong devbrandonlong commented Aug 15, 2022

This PR introduces/fixes the following:

Docs

  • dart_code_viewer2 was added in conjunction with a new ComponentState class attribute String? codeSample to allow flutterbook contributors to effectively provide code snippets outside of any markdown/documentation they'd like to provide for a given component state
  • The Component class now has a String? componentMarkdown to allow for component-wide documentation. This should allow stories to have a bit more
  • A new attribute CodeSampleThemeData? codeSampleTheme has been added to allow teams to customize the theme of the code viewer
  • Example:
    code_viewer

Multi-Theme Support

  • A new themes argument has been added to Flutterbook to enable teams with 3+ themes to view the app in every theme. This attribute will take priority over the existing theme and darkTheme attributes if it is set.
  • Example:
    multi theme

Panning updates

  • Panning a component is now behind its own toggle in the tab bar
  • Example:
    panning

@devbrandonlong
Copy link
Contributor Author

@Josiassejod1
@Doetheman

Copy link
Owner

@GhostWalker562 GhostWalker562 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Simply glanced over everything.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Josiassejod1 Josiassejod1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@Josiassejod1 Josiassejod1 merged commit c8da44b into GhostWalker562:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants