New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panning, Add DartCodeViewer, Add Multi Theme support #17
Merged
Josiassejod1
merged 13 commits into
GhostWalker562:master
from
devbrandonlong:fix-panning
Aug 16, 2022
Merged
Fix panning, Add DartCodeViewer, Add Multi Theme support #17
Josiassejod1
merged 13 commits into
GhostWalker562:master
from
devbrandonlong:fix-panning
Aug 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbrandonlong
force-pushed
the
fix-panning
branch
from
August 15, 2022 13:28
5984bf5
to
6f3c299
Compare
devbrandonlong
force-pushed
the
fix-panning
branch
from
August 15, 2022 14:15
b82665a
to
da4efee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Simply glanced over everything.
Josiassejod1
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well
Josiassejod1
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces/fixes the following:
Docs
ComponentState
class attributeString? codeSample
to allow flutterbook contributors to effectively provide code snippets outside of any markdown/documentation they'd like to provide for a given component stateComponent
class now has aString? componentMarkdown
to allow for component-wide documentation. This should allow stories to have a bit moreCodeSampleThemeData? codeSampleTheme
has been added to allow teams to customize the theme of the code viewerMulti-Theme Support
themes
argument has been added toFlutterbook
to enable teams with 3+ themes to view the app in every theme. This attribute will take priority over the existingtheme
anddarkTheme
attributes if it is set.Panning updates