Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering users crashes if a superuser account exists with empty GitHub id #562

Open
JobDoesburg opened this issue Jan 22, 2022 · 1 comment

Comments

@JobDoesburg
Copy link
Contributor

One-sentence description

Registering users crashes if a superuser account exists with empty GitHub id

How to reproduce the bug

  1. Have a (super) user with empty GitHub id
  2. Register a new user
  3. The registration form crashes on a failed UNIQUENESS constraint

Expected behaviour

  1. Not crash (even if a superuser with empty GitHub id exists, still, the Django form shouldn't even create a user with empty GitHub id). I think the problem here is that first, an normal user object is created and only then the form details written to it (after form validation)
  2. It should not be possible to have users with empty GitHub id (even if they are created by code, such as in entrypoint.sh)
@JobDoesburg
Copy link
Contributor Author

image

image

weird, a value is actually being inserted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant