Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiHole-plugin in Organizr has partially missing background due to inheritance of "bg-inverse" lately #320

Closed
systemofapwne opened this issue Feb 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@systemofapwne
Copy link

Describe the bug
Some weeks ago, my PiHole indicator in organizr started missing the background-color for Queries Blocked, Percent Blocked and Domains on Blocklist but not for Total queries.
I might have traced it back to around this commit, where the CSS class bg-inverse has been modified: fe73962#diff-57cd7f84a310a63392db1f3014f1fd5423e97478b3d75d62a536bc9f5b0b6277

It looks like, that the three panels in question derive their style also from bg-inverse (which sets background: transparent !important;) while the Total queries does not and thus is unaffected.

Theme Install Method

  • CSS include directly in Organizr, pointing to this very git-repo, locally hosted on my webserver on latest commit@master.
@import url("https://MY.TLD/themepark/css/base/organizr/organizr-base.css");
@import url("https://MY.TLD/themepark/css/theme-options/nord.css");

Application Info

  • Application: Organizr
  • Version: Latest git commit
  • Branch: v2-develop
  • Container: organizr/organizr

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings/Tab Editor/Homepage-Elements
  2. Click on PI-HOLE/connection
  3. Point it to your http://<Piholeip>/admin/ page
  4. Watch the "Homepage" of Organizr missing the panel-backgrounds

Expected behavior
Panel-Backgrounds all show properly

Screenshots
What I expect to see
Screenshot_20220203_223057

What I actually see
Screenshot_20220203_223158

Desktop:

  • OS: Manjaro Linux
  • Browser: Chrome, Firefox
  • Version: Most recent
@systemofapwne systemofapwne added the bug Something isn't working label Feb 3, 2022
GilbN added a commit that referenced this issue Feb 5, 2022
@GilbN
Copy link
Collaborator

GilbN commented Feb 5, 2022

Pushed a fix to dev. Please test develop.theme-park.dev

@systemofapwne
Copy link
Author

I can confirm, that this fixed it.

@GilbN GilbN closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants