Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most themes (for gitea) leave line numbers unreadable #321

Closed
embeddedpenguin opened this issue Feb 11, 2022 · 4 comments
Closed

Most themes (for gitea) leave line numbers unreadable #321

embeddedpenguin opened this issue Feb 11, 2022 · 4 comments

Comments

@embeddedpenguin
Copy link

onedark:
image

overseerr:
image

I could change this in .lines-num if that helps at all. I don't want to submit a pr for a css change because I would have no idea what I'm doing.

Most of the themes mentioned here are affected by this.

GilbN added a commit that referenced this issue Feb 13, 2022
@GilbN
Copy link
Collaborator

GilbN commented Feb 13, 2022

onedark: image

overseerr: image

I could change this in .lines-num if that helps at all. I don't want to submit a pr for a css change because I would have no idea what I'm doing.

Most of the themes mentioned here are affected by this.

Pushed a fix to dev. Please test develop.theme-park.dev

@embeddedpenguin
Copy link
Author

onedark: image
overseerr: image
I could change this in .lines-num if that helps at all. I don't want to submit a pr for a css change because I would have no idea what I'm doing.
Most of the themes mentioned here are affected by this.

Pushed a fix to dev. Please test develop.theme-park.dev

The way I'm applying these themes is via this method: https://docs.theme-park.dev/themes/gitea/#adding-the-themes-in-gitea I'm not sure how to test changes on another branch because https://theme-park.dev/css/base/gitea/<theme_name_here>.css is hard pointing at a page.

@embeddedpenguin
Copy link
Author

onedark: image
overseerr: image
I could change this in .lines-num if that helps at all. I don't want to submit a pr for a css change because I would have no idea what I'm doing.
Most of the themes mentioned here are affected by this.

Pushed a fix to dev. Please test develop.theme-park.dev

The way I'm applying these themes is via this method: https://docs.theme-park.dev/themes/gitea/#adding-the-themes-in-gitea I'm not sure how to test changes on another branch because https://theme-park.dev/css/base/gitea/<theme_name_here>.css is hard pointing at a page.

Ok nevermind I realize now... I didn't realize "develop" was a subdomain to theme-park.dev. Tested and working great!

onedark
image

organizr
image

overseerr
image

@embeddedpenguin
Copy link
Author

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants