Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand/change Ensemble to include AbsEndcap #55

Open
GilesStrong opened this issue Jun 6, 2020 · 0 comments
Open

Expand/change Ensemble to include AbsEndcap #55

GilesStrong opened this issue Jun 6, 2020 · 0 comments
Labels
good first issue Good for newcomers improvement Something which would improve current status, but not add anything new low priority Not urgent and won't degrade with time

Comments

@GilesStrong
Copy link
Owner

Current state

AbsEndcap acts as a wrapper to apply fixed functions to the outputs of models that were trained on proxy objectives, e.g. to compute the invariant mass from a model that outputs the 3-momenta of two particles (see Multi_Target_Regression example).

AbsEndcap currently does this via a .forward method and a .predict method, so in theory, this should also work for Ensembles of models. Wrapping an Ensemble, though, then removes many of the benefits of that the Ensemble class offers.

Proposal

The Ensemble class is extended to include the ability to add an AbsEndcap, through which the outputs of all internal models will be passed.

@GilesStrong GilesStrong added good first issue Good for newcomers improvement Something which would improve current status, but not add anything new low priority Not urgent and won't degrade with time labels Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Something which would improve current status, but not add anything new low priority Not urgent and won't degrade with time
Projects
None yet
Development

No branches or pull requests

1 participant