Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Literal types (aka move to Python 3.8) #65

Open
GilesStrong opened this issue Jun 6, 2020 · 0 comments
Open

Add Literal types (aka move to Python 3.8) #65

GilesStrong opened this issue Jun 6, 2020 · 0 comments
Labels
disruptive Something which will likely cause large or breaking changes enhancement New feature or request idea A potential change that might be good or bad investigation Something which might require a careful study

Comments

@GilesStrong
Copy link
Owner

GilesStrong commented Jun 6, 2020

In a few locations, string values arguments are used in LUMIN and specific value are expected. Python 3.8 introduced literal types (https://realpython.com/python38-new-features/), where the set of expected values can be stated in the method definitions. This is potentially useful, but would then require setting the minimum version of python for LUMIN from 3.6 to 3.8, which could be disruptive to our user-base. (Although, since I doubt we actually have a consistent user-base, this change may not be disruptive and should be done sooner rather than later).

@GilesStrong GilesStrong added enhancement New feature or request idea A potential change that might be good or bad investigation Something which might require a careful study disruptive Something which will likely cause large or breaking changes labels Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disruptive Something which will likely cause large or breaking changes enhancement New feature or request idea A potential change that might be good or bad investigation Something which might require a careful study
Projects
None yet
Development

No branches or pull requests

1 participant